chore: build flamepy during installation.

[k82cn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the loading of the flamepy Python SDK by integrating a wheel-building step into the flmadm installation workflow. By pre-compiling flamepy into a wheel, applications can now load it more efficiently from a cached location, reducing runtime overhead associated with source-based installations and enhancing overall performance.

Highlights

• Pre-built Python Wheels: The flamepy Python SDK is now pre-built into a wheel during the flmadm install process, rather than being loaded directly from source at runtime. This change aims to improve application startup performance by leveraging cached wheels.
• Installation Process Update: The flmadm installation manager has been updated to include a new step for building the flamepy wheel. It creates a dedicated wheels directory and uses the uv tool to perform the build.
• Application Launch Command Modification: The default application configuration in common now uses the --find-links option with uv run to locate the pre-built flamepy wheel, simplifying the dependency reference from a file path to just the package name.
• Uninstallation Cleanup: The uninstallation process in flmadm has been extended to properly remove the newly created wheels directory, ensuring a clean removal of installed components.

Changelog

• common/src/lib.rs
  • Replaced flamepy_sdk_path with flamepy_wheels_dir to point to the new wheels directory.
  • Updated the uv run command arguments to use --find-links with the wheels directory and reference flamepy by name, instead of a direct file path to the SDK source.
• flmadm/src/managers/installation.rs
  • Removed the creation of README.txt in the Python SDK directory.
  • Added a new private function build_python_wheel to handle the creation of the wheels directory and execute uv build for flamepy.
  • Integrated the build_python_wheel call into the main installation logic after copying the SDK.
  • Added logic to the uninstall method to remove the wheels directory if it exists.
• flmadm/src/types.rs
  • Added a wheels field of type PathBuf to the InstallationPaths struct.
  • Initialized the wheels field in the InstallationPaths::new constructor to prefix.join("wheels").

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a good performance optimization by pre-building the flamepy Python SDK into a wheel during installation. This avoids rebuilding it on every run. The changes look solid, but I've found one potential issue in flmadm/src/managers/installation.rs where an .unwrap() could lead to a panic during installation if the path contains non-UTF-8 characters. I've left a specific comment with a suggested fix for this.