-
Notifications
You must be signed in to change notification settings - Fork 12
fix: use UV_CACHE_DIR for dependency caching #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use uv pip install --target instead of non-existent uv pip download
- Set UV_CACHE_DIR to ${FLAME_HOME}/data/cache/uv during installation
- Add UV_CACHE_DIR env var to flmrun application
- Expand env vars in executor_manager for environment settings
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Summary of ChangesHello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical issues with flamepy's dependency caching, ensuring that Python package dependencies are correctly cached during installation and made available to applications at runtime. It rectifies the use of an incorrect Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the dependency caching mechanism by using uv pip install --target to populate a dedicated cache directory and configuring the runtime to use it. The changes are logical and well-implemented. I've identified one minor improvement opportunity in error handling to make the installation process more robust by failing explicitly if a temporary directory cannot be created.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
This PR fixes the dependency caching mechanism for flamepy so that cached packages are available at runtime.
Changes
uv pip install --targetinstead of non-existentuv pip downloadto populate the cacheUV_CACHE_DIRto${FLAME_HOME}/data/cache/uvduring installationUV_CACHE_DIRenvironment variable to theflmrunapplication configuration${FLAME_HOME}) in application environment settingsWhy this is needed
PR #355 introduced flamepy wheel building during installation, but the dependency caching used
uv pip downloadwhich doesn't exist. Additionally, the cache was stored in the default location (~/.cache/uv) which may not be available at runtime in Docker containers.This PR ensures:
flmadm install${FLAME_HOME}/data/cache/uv)flmrunapplication uses the same cache location at runtime