Skip to content

feat: Allow empty host on WithRoute #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgkawell merged 2 commits into from
Mar 3, 2025
Merged

feat: Allow empty host on WithRoute #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
714cd83
remove host requirement in `WithRoute`
jgkawell Mar 3, 2025
7812bd5
added `Ping()` call to `postgres/bun.Open()`
jgkawell Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/chassis/networking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ func (c *Runtime) setAndValidateRoute(route *ntv1.Route) *ntv1.Route {
if route.Match == nil {
c.logger.Panic("route requested but no match provided")
}
if route.Match.Host == "" {
route.Match.Host = c.config.GetString("service.network.external.host")
}
if route.Match.Host == "" {
c.logger.Panic("route requested but no host provided in the match")
}
if route.Endpoint == nil {
route.Endpoint = &ntv1.Endpoint{
Host: c.getConfigInternalHost(),
Expand Down
2 changes: 1 addition & 1 deletion pkg/repositories/postgres/bun/bun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (r *repository) Open(ctx context.Context, config chassis.Config) error {
sqldb := sql.OpenDB(pgdriver.NewConnector(pgdriver.WithDSN(url)))
client := bun.NewDB(sqldb, pgdialect.New())
r.client = client
return nil
return r.Ping(ctx)
}

func (r *repository) Close(ctx context.Context) error {
Expand Down
Loading