Conversation
jgkawell
added a commit
that referenced
this pull request
Mar 4, 2025
This PR fixes an issue where registered routes with the same host would be rejected by envoy. Hosts (called domains in the envoy config) must be unique across all virtual hosts ([ref](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-virtualhost)). In a previous chassis PR (#67), the requirement for a host to be set when calling `WithRoute` was removed. This PR now will add routes without a specified host to a default host (which is `*` for now but should be configurable). The other changes are just little cleanup items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy requires unique domains for all virtual hosts within the same route configuration. This was causing issues with multiple services registering under the same domain/host through fuse. This PR removes the requirement to specify a host when registering routes and #65 updates fuse to add routes with no defined host to a default virtual host.
Oh and I also added a
Ping()call to therepositories/postgres/bunclient'sOpen()so that the database connection is actually verified on boot.