Skip to content

DAOS-18592 control: Only use joined ranks when calculating pool size #17580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tanabarr wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −5
Draft

DAOS-18592 control: Only use joined ranks when calculating pool size #17580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/control/lib/control/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,10 +1288,34 @@ func getMaxPoolSize(ctx context.Context, rpcClient UnaryInvoker, createReq *Pool
return 0, 0, errors.New("invalid mem-ratio, should not be greater than one")
}

// Verify that the DAOS system is ready before attempting to query storage.
if _, err := SystemQuery(ctx, rpcClient, &SystemQueryReq{}); err != nil {
return 0, 0, err
// Verify that the DAOS system is ready before attempting to query storage and record joined.
queryResp, err := SystemQuery(ctx, rpcClient, &SystemQueryReq{})
if err != nil {
return 0, 0, errors.Wrap(err, "getMaxPoolSize: SystemQuery")
}
joinedRanks := []ranklist.Rank{}
for _, member := range queryResp.Members {
if member.State == system.MemberStateJoined {
joinedRanks = append(joinedRanks, member.Rank)
}
}

// Refuse if any requested ranks are not joined, update ranklist to contain only joined ranks.
approvedRanks := []ranklist.Rank{}
if len(createReq.Ranks) == 0 {
approvedRanks = joinedRanks
} else {
// Generate function to verify a rank is in the provided rank slice.
filterJoined := newFilterRankFunc(ranklist.RankList(joinedRanks))
for _, rank := range createReq.Ranks {
if !filterJoined(rank) {
return 0, 0, errors.Errorf("specified rank %d is not joined", rank)
}
approvedRanks = append(approvedRanks, rank)
}
}
filterRank := newFilterRankFunc(ranklist.RankList(approvedRanks))
Copy link
Contributor

@knard38 knard38 Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newFilterRankFunc() should probably be updated to not support empty RankList as all ranks.
From my understanding, if the new filtering on joined ranks produce an empty list it will be interpreted as all ranks by newFilterRankFunc().

createReq.Ranks = approvedRanks

scanReq := &StorageScanReq{
Usage: true,
Expand All @@ -1307,8 +1331,6 @@ func getMaxPoolSize(ctx context.Context, rpcClient UnaryInvoker, createReq *Pool
return 0, 0, errors.New("Empty host storage response from StorageScan")
}

// Generate function to verify a rank is in the provided rank slice.
filterRank := newFilterRankFunc(ranklist.RankList(createReq.Ranks))
rankNVMeFreeSpace := make(rankFreeSpaceMap)
scmBytes := uint64(math.MaxUint64)
for _, key := range scanResp.HostStorage.Keys() {
Expand Down
Loading