DAOS-18592 control: Only use joined ranks when calculating pool size#17580
DAOS-18592 control: Only use joined ranks when calculating pool size#17580
Conversation
Features: pool Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'Pool create with percentage fails after stopping rank 0' |
|
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17580/1/execution/node/1274/log |
knard38
left a comment
There was a problem hiding this comment.
The uni test TestControl_getMaxPoolSize() should probably be update with these new use cases.
| approvedRanks = append(approvedRanks, rank) | ||
| } | ||
| } | ||
| filterRank := newFilterRankFunc(ranklist.RankList(approvedRanks)) |
There was a problem hiding this comment.
The newFilterRankFunc() should probably be updated to not support empty RankList as all ranks.
From my understanding, if the new filtering on joined ranks produce an empty list it will be interpreted as all ranks by newFilterRankFunc().
In order to avoid failing pool create with storage percentage (-z X%)
when ranks have been stopped, only take into account joined ranks when
calculating maximum available pool sizes.
Features: pool
Steps for the author:
After all prior steps are complete: