Avoid using isEqualTo to test equals/hashCode contracts #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @centrumek, apologies again for the slow feedback! I've been digesting this topic for a bit, and I think it would be more beneficial to mention this in the Javadoc, closer to the actual usage. For this reason, I prepared assertj/assertj#4101, adding you as a co-author as I took inspiration from your work 🙂 I'd be happy to have your review there, if you have time! In light of this, I'm closing this PR as superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves assertj/assertj#3865
@scordio pls check whether it aligns with your thoughts