Flink: Backport TableMaintenance Support Coordinator Lock to 1.20 and 2.0#15438
Merged
pvary merged 2 commits intoapache:mainfrom Feb 25, 2026
Merged
Flink: Backport TableMaintenance Support Coordinator Lock to 1.20 and 2.0#15438pvary merged 2 commits intoapache:mainfrom
pvary merged 2 commits intoapache:mainfrom
Conversation
Guosmilesmile
force-pushed
the
backport_coordinator_lock
branch
2 times, most recently
from
7e70057 to
cc5ca72
Compare
Guosmilesmile
commented
Feb 25, 2026
Contributor
Author
Guosmilesmile
left a comment
Guosmilesmile
left a comment
There was a problem hiding this comment.
Changes in 1.20
Comment on lines
+60
to
+61
| lockRemoverOperator.setup( | ||
| parameters.getContainingTask(), parameters.getStreamConfig(), parameters.getOutput()); |
Contributor
Author
There was a problem hiding this comment.
In 1.20 we should add call setup().
Comment on lines
+82
to
+83
| triggerManagerOperator.setup( | ||
| parameters.getContainingTask(), parameters.getStreamConfig(), parameters.getOutput()); |
Contributor
Author
There was a problem hiding this comment.
In 1.20 we should add call setup().
Guosmilesmile
force-pushed
the
backport_coordinator_lock
branch
from
cc5ca72 to
b43499e
Compare
Guosmilesmile
commented
Feb 25, 2026
| Preconditions.checkArgument( | ||
| lockCheckDelayMs > 0, "Minimum lock delay rate should be at least 1 ms."); | ||
|
|
||
| this.processingTimeService = parameters.getProcessingTimeService(); |
Contributor
Author
There was a problem hiding this comment.
Add init processingTimeService from parameters.getProcessingTimeService().
Guosmilesmile
force-pushed
the
backport_coordinator_lock
branch
from
b43499e to
bc29766
Compare
Guosmilesmile
commented
Feb 25, 2026
| minFireDelayMs, | ||
| lockCheckDelayMs, | ||
| lockId); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Add parameters with TestProcessingTimeService
Guosmilesmile
force-pushed
the
backport_coordinator_lock
branch
from
bc29766 to
ba611d5
Compare
Guosmilesmile
commented
Feb 25, 2026
Comment on lines
+52
to
+60
| LockRemoverOperator( | ||
| StreamOperatorParameters<Void> parameters, | ||
| OperatorEventGateway operatorEventGateway, | ||
| String tableName, | ||
| List<String> maintenanceTaskNames) { | ||
| this.tableName = tableName; | ||
| this.operatorEventGateway = operatorEventGateway; | ||
| this.maintenanceTaskNames = maintenanceTaskNames; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Remove super(parameters);, The parent class has a no-argument constructor.
Guosmilesmile
commented
Feb 25, 2026
Comment on lines
+88
to
+99
| TriggerManagerOperator( | ||
| StreamOperatorParameters<Trigger> parameters, | ||
| OperatorEventGateway operatorEventGateway, | ||
| List<String> maintenanceTaskNames, | ||
| List<TriggerEvaluator> evaluators, | ||
| long minFireDelayMs, | ||
| long lockCheckDelayMs, | ||
| String tableName) { | ||
| Preconditions.checkArgument( | ||
| maintenanceTaskNames != null && !maintenanceTaskNames.isEmpty(), | ||
| "Invalid maintenance task names: null or empty"); | ||
| Preconditions.checkArgument( |
Contributor
Author
There was a problem hiding this comment.
Remove super(parameters);, The parent class has a no-argument constructor.
Contributor
Author
mxm
approved these changes
Feb 25, 2026
pvary
approved these changes
Feb 25, 2026
Contributor
|
Merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is a backport for #15151 to Flink 1.20 and 2.0.
2.0 is a clearn backport, 1.20 need some small change.