Add get_training_input to storage_utils #438
Merged
+572
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Did a pass here and left some comments/questions
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
mkolodner-sc
approved these changes
Jan 21, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle for the work!
svij-sc
reviewed
Jan 23, 2026
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
python/tests/unit/distributed/graph_store/storage_utils_test.py
Outdated
Show resolved
Hide resolved
kmontemayor2-sc
requested review from
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Add server-side util so we can remotely fetch the training input.
Since this is kind of a big PR not adding the client-side equivalent in this one :P
Again this is server-side code, and it's really meant to be called by users.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO