[Vanilla Fix] Fixed the bug that crashing technos can be attack and gain expirence

[NetsuNegi]

No description provided.

[phoboscn-bot]

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/274/1

[github-actions]

Nightly build for this pull request:

• compiled-dll-f0ba551e72c34fe018274a39d7a765640d47736d.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[TaranDahl]

What is the difference between Infantry and Unit?
Why does Infantry have this bug while Unit does not?
I think this correction should be placed at the position that causes Infantry and Unit to exhibit different behaviors. The current Hook position does not seem to distinguish between Infantry and Unit.

[TaranDahl]

Please address the issue above.

[Coronia]

@TaranDahl please review it again, it already has those issues commented

[TaranDahl]

Reposted from Phobos CN :

[quote="NetsuNegi, post:10, topic:274"]
The infantry godmode code is at 0x51BC96, and I don't know what it's for.
[/quote]

[quote="NetsuNegi, post:10, topic:274"]
However, when the vehicle sinks, it also locks at 1 HP.
[/quote]

Have you tried removing them?

[NetsuNegi]

Reposted from Phobos CN :

[quote="NetsuNegi, post:10, topic:274"] The infantry godmode code is at 0x51BC96, and I don't know what it's for. [/quote]

[quote="NetsuNegi, post:10, topic:274"] However, when the vehicle sinks, it also locks at 1 HP. [/quote]

Have you tried removing them?

No and I don't want try it.
I think this should open a separate pull request.

[TaranDahl]

As mentioned above, I believe it fails to address the problem at its root cause, so the way of solving the problem is incorrect, and this is a relevant issue.
The author considers this an irrelevant issue and should be addressed elsewhere.
@Metadorius You decide whether this problem should be solved here.

[Metadorius]

why exactly did you remove this complicated condition?

[Metadorius]

not sure why this got closed, I was simply asking

[TaranDahl]

Suggestion, if you don't want to be forced to make major changes after submitting a PR:

talk with them about key design aspects before you even submit a contribution

In PR 1827.

[NetsuNegi]

not sure why this got closed, I was simply asking

The closure of this pull request is not related to your ask.