Add Electrical Measurement reactive power entity#670
Draft
TheJulianJES wants to merge 4 commits intozigpy:devfrom
Draft
Add Electrical Measurement reactive power entity#670TheJulianJES wants to merge 4 commits intozigpy:devfrom
TheJulianJES wants to merge 4 commits intozigpy:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #670 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 62 62
Lines 10731 10741 +10
=======================================
+ Hits 10457 10467 +10
Misses 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds the reactive power entity based on the
ElectricalMeasurementcluster.Additional information
Supported by Ubisys devices (read/polling only).
For now, I've limited this PR to only include an entity for Phase A, not B, not C, and also not the total reactive power.