Remove non-ZCL siren select entities for basic sirens#666
Draft
TheJulianJES wants to merge 2 commits intozigpy:devfrom
Draft
Remove non-ZCL siren select entities for basic sirens#666TheJulianJES wants to merge 2 commits intozigpy:devfrom
TheJulianJES wants to merge 2 commits intozigpy:devfrom
Conversation
Draft
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #666 +/- ##
==========================================
- Coverage 97.44% 97.43% -0.01%
==========================================
Files 62 62
Lines 10731 10734 +3
==========================================
+ Hits 10457 10459 +2
- Misses 274 275 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT. TODO: Move
"siren_basic"string as constant tozha-quirks, so we can later import it.Proposed change
This removes the non-ZCL select entities created for sirens IF they hint
"siren_basic"as an "exposed feature" from quirks.This is done by adding
not_exposed_featuresto discovery. This might also come in handy for future entities. This was one of the suggested options to achieve this from the PR linked below.Other options would have included overriding
is_supportedin all three classes to ignore based on the exposed features OR creating three more classes and making use offeature_priorityto always returnFalseforis_supportedin the basic siren ZCL select entities. IMO, thenot_exposed_featuresis cleaner and "fine".Additional information
Related (and see for more description):