Deduplicate check runs to prevent stuck polling#31
Open
arferreira wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions can produce duplicate check runs for the same job name when workflows are re-triggered or race. The older run stays in_progress forever while the newer one completes. Fila's poll_checks waits for all check runs to complete, so a single orphaned run blocks the entire batch until timeout.
This deduplicates check runs by name, keeping only the latest (highest ID) per name before evaluating completion status. Also adds the id field to GhCheckRun.
Found this in production on the Table-Connect monorepo where path-filtered workflows combined with discord-notify re-triggers consistently produced duplicate runs.