Fix dequeue and recover orphaned PRs on startup#23
Merged
fila-ci[bot] merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Contributor
Author
|
@fila ship |
Contributor
|
Commit e50161d has been added to the merge queue by @arferreira. |
Contributor
Author
|
@fila cancel |
Contributor
|
PR #23 has been removed from the merge queue by @arferreira. |
Contributor
Contributor
Author
|
@fila ship |
Contributor
|
Commit e50161d has been added to the merge queue by @arferreira. |
Contributor
|
#23 is already merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs:
dequeue() only cancelled PRs with status "queued". If a PR was in "testing" or "batched" and the GitHub PR got closed, dequeue silently did nothing — the PR stayed stuck forever. Fixed by matching any active status (queued, testing, batched).
If the runner gets killed mid-merge (e.g. during a redeploy), PRs stuck in "testing" or "batched" are never re-processed because the runner only looks at "queued". Added recover_orphaned() that runs on startup and requeues them.