Added more regexs cases for different devices/email providers#32
Open
iamshwin wants to merge 5 commits intozapier:masterfrom
Open
Added more regexs cases for different devices/email providers#32iamshwin wants to merge 5 commits intozapier:masterfrom
iamshwin wants to merge 5 commits intozapier:masterfrom
Conversation
iamshwin
changed the title
Contributor
|
Heyo @iamshwin! Thanks for contributing. A couple things: 1/ I don't see new tests that verify your regex solves the use cases you're trying to solve for. 2/ Also, I don't think the code formatting is a significant improvement. However, I do think changes can be made. Can you separate the two major changes (1) regex change made (include tests) and (2) the formatting into two PRs? The latter we can discuss and determine a cleaner way to perhaps auto-format code to some standard. |
roycehaynes
suggested changes
Nov 1, 2018
Contributor
roycehaynes
left a comment
roycehaynes
left a comment
There was a problem hiding this comment.
@iamshwin See comments in PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improved code formatting.