Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

xen-bugtool/readKeyValueFile(): Remove unused code and simplify the remaining code

  • xen-bugtool/readKeyValueFile(): Use contextmanager for open/close

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
… allowed_keys

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
…atches

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@xenserver xenserver deleted a comment from codecov bot Sep 21, 2025
… condition away

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the readKeyValueFile() function in xen-bugtool by removing unused parameters and dead code while improving resource management. The changes also update GitHub workflow configuration and codecov settings.

  • Removes unused allowed_keys and strip_quotes parameters from readKeyValueFile()
  • Replaces manual file handling with context manager for proper resource management
  • Updates SonarCloud action and codecov configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
xen-bugtool Simplifies readKeyValueFile() function by removing unused parameters and using context manager
.github/workflows/main.yml Updates SonarCloud action to SonarQube scan action with error handling
.codecov.yml Updates codecov configuration comments and removed_code_behavior setting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…thout =

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the cleanup-outdated-cruft-in-readKeyValueFile branch from 9fa2cb9 to c350063 Compare September 22, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant