Draft
Conversation
# Conflicts: # Makefile # decomp2d/io.f90 # src/BC-dbg-schemes.f90 # src/CMakeLists.txt # src/Case-Cylinder-wake.f90 # src/acl_utils.f90 # src/case.f90 # src/forces.f90 # src/genepsi3d.f90 # src/ibm.f90 # src/module_param.f90 # src/navier.f90 # src/parameters.f90 # src/tools.f90 # src/xcompact3d.f90
…to compile and have ignored i2dsim option
pbartholomew08
requested changes
Mar 31, 2025
Member
There was a problem hiding this comment.
Remove this file, it may conflict with other users' settings.
Member
There was a problem hiding this comment.
Remove this file - Xcompact3d should be built with CMake now, and the Makefile was removed previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability for full 3D force and torque evaluation for immersed ellipsoids. The main addition is a new case (ellip) but also forces.f90 now calculates forces in every axis, as well as calculating torque when required. Significant change to the whole repository is that all derivative and filter functions have been altered to take an integer which gets used as a case statement to calculate the required velocity for interpolation. I have tried to make the rationale for this clear in comments but am happy to discuss (this was necessary as rotating solids no longer have constant velocities over their surface). I have attempted to tidy up some bits but there is still some logic for the solid motion that probably shouldn't be in the main xcompact3d.f90 script - I am sure I have missed something elsewhere too.
Many thanks to Paul for his help with this project.