Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for TPSL (Take Profit / Stop Loss) order type and makes create_order_object keyword-only.
Changes:
- Added
OrderType.TPSLsupport increate_order_objectwith validation rules for TPSL-specific constraints - Made
create_order_objectaccept keyword-only arguments (breaking change), bumping version to0.1.0 - Added
cancelled_qtyfield and madepriceoptional onOpenOrderModelto accommodate TPSL orders
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| x10/perpetual/order_object.py | Core TPSL order creation logic, keyword-only args, settlement/side handling |
| x10/perpetual/orders.py | Made price optional, added cancelled_qty, added docstring |
| tests/perpetual/test_order_object.py | Tests for partial and position TPSL order creation |
| pyproject.toml | Version bump to 0.1.0 |
| examples/create_position_tpsl_order.py | New example for position TPSL orders |
| examples/create_partial_tpsl_order.py | New example for partial TPSL orders |
| examples/placed_order_example_advanced.py | Updated to use keyword args |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ex10ded
previously approved these changes
Mar 17, 2026
Contributor
ex10ded
left a comment
There was a problem hiding this comment.
we will need to bump major version here
Contributor
Author
agree, bumped minor 🤦 |
ex10ded
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New:
order_type=OrderType.TPSL(seecreate_partial_tpsl_orderandcreate_position_tpsl_orderexamples)💥 Breaking:
create_order_objectnow accepts names args only, in the next PRs order object creation process will be reworked to be more user friendly (builder pattern)