Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
============================================
+ Coverage 30.47% 30.48% +0.01%
Complexity 1020 1020
============================================
Files 134 134
Lines 13315 13320 +5
Branches 2566 2567 +1
============================================
+ Hits 4058 4061 +3
- Misses 8753 8754 +1
- Partials 504 505 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
piraveena
reviewed
Jul 8, 2025
| */ | ||
| Role createRole(Role role) throws CharonException, ConflictException, NotImplementedException, BadRequestException; | ||
| Role createRole(Role role) throws CharonException, ConflictException, NotImplementedException, | ||
| BadRequestException, ForbiddenException; |
Contributor
There was a problem hiding this comment.
won't this introduce any behavioural change? Then we have to do a version bump
Contributor
There was a problem hiding this comment.
So far ForbiddenException was not thrown.
Now also throwing for the cases introduced in this effort.
Do we still need to consider this as a behavioural change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add ForbiddenException to method signatures in interfaces and default implementations to handle cases where operations are forbidden. . This is needed as part of fine-grained scope validation. In the SCIM layer, fine-grained scope validation checks will be performed; if the scope is not available, the ForbiddenException will be thrown.
Similar PR:
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning