fix/added an update to targetLayout for each change in targ… #3935
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etFrame, now allows for proper re-adjusting of hint location due to safeArea calculation.
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
yotam-wix
commented
Feb 12, 2026
| setTargetLayout(targetFrame); | ||
| setTargetLayoutInWindow(targetFrame); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Collaborator
Author
There was a problem hiding this comment.
not sure regarding this line, cursor was insisting it's necessary due to lint issues that may come up without it but I didn't see an issue when removing this line, so leaving it up to your opinion..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hint - fix targetFrame prop not updating after mount
When targetFrame is passed as a prop, useHintLayout stored it only as the useState initial value, so any changes after mount were ignored. Added a useEffect to sync internal state when targetFrame changes.
Changelog
Hint - targetFrame prop now correctly repositions when updated after mount
Additional info
None