Draft
Conversation
Contributor
Author
|
So this does not work as nicely as expected, because it turns out that writing every item to the storage again does increase the total size used by rocksdb, even if the written data is exactly the same as the existing data. This resulted in my machine running out of disk space during the rewind, and that caused a fatal error leaving the storage in an invalid state, with error "OutputNotFound" when trying to synchronize. And after that the only way to recover is to do another rewind... |
6b3142a to
9781266
Compare
3e8bb07 to
ed5e532
Compare
d28f025 to
5bf0421
Compare
9e47bbb to
eece408
Compare
1679d32 to
1b59db0
Compare
54b59f2 to
96c6d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some flags to the rewind JSON-RPC method to allow manually fixing storage with missing items, issue #2102
Command to process all the blocks again to fix missing entries in storage:
{"jsonrpc":"2.0","id":"1","method":"rewind","params":{"mode":{"write_items_to_storage": true}}}The original use case of trying to recover a forked node still works with the same syntax:
{"jsonrpc":"2.0","id":"1","method":"rewind","params":[10000]}The main blocker is that if there is actually a missing block, the rewind process stops and the node enters the normal synchronization process which is much slower than a rewind. But eventually it fixes the issue, it is just very slow.
Marking as a draft while I check if I can implement some "resume" functionality to avoid the slow synchronization.