Skip to content

Conversation

@omrimend
Copy link

@omrimend omrimend commented Nov 4, 2025

Transitive library org.mozilla.rhino uses version 1.7.7.2 (used originally by reacability using unified-agent) has possible OutOfMemory due to infinite loop on parsing Issue Objects are only thread-safe when feature is enabled. (https://github.com/mozilla/rhino/blob/master/RELEASE-NOTES.md#rhino-178)

Using override to use version 1.7.8 fixes this issue.

Resolves: SCA-4120


Note

Updates org.mozilla:rhino in wss-agent-hash-calculator/pom.xml from 1.7.7.2 to 1.7.8.

Written by Cursor Bugbot for commit ef57496. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated a core library dependency for improved compatibility and stability.

Transitive library org.mozilla.rhino uses version 1.7.7.2 (used originally by reacability using unified-agent) has possible OutOfMemory due to infinite loop on parsing Issue Objects are only thread-safe when feature is enabled. (https://github.com/mozilla/rhino/blob/master/RELEASE-NOTES.md#rhino-178)

Using override to use version 1.7.8 fixes this issue.

Resolves: SCA-4120
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

The Rhino JavaScript parser dependency version is updated from 1.7.7.2 to 1.7.8 in the wss-agent-hash-calculator/pom.xml file. This is a patch-level version bump with no other modifications to the project configuration or functional code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification (pom.xml) containing only a version string update
  • No logic changes, no configuration alterations, no code refactoring
  • Straightforward dependency version bump that follows semantic versioning (patch release)

Optional consideration: Verify the Rhino 1.7.8 release notes for any breaking changes or deprecations, though patch releases typically contain only bug fixes.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating Rhino library to fix an OutOfMemory issue. This aligns with the PR's core objective of bumping the Rhino dependency version to resolve a known bug.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch omri-SCA-4120

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49b956d and ef57496.

📒 Files selected for processing (1)
  • wss-agent-hash-calculator/pom.xml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: - Feedback will only be given on issues that could cause bugs or involve very bad practices.

  • Comments will be kept concise and focused on critical areas.

Files:

  • wss-agent-hash-calculator/pom.xml
🔇 Additional comments (1)
wss-agent-hash-calculator/pom.xml (1)

54-58: Rhino version bump is correct and addresses the reported issue.

The update to version 1.7.8 resolves issue #323 "Possible OutOfMemory due to infinite loop on parsing", which directly addresses the PR objective. This is a justified patch-level update with no breaking changes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants