chore: upgrade eslint from v8 to v9#646
Merged
alexander-akait merged 4 commits intowebpack:masterfrom Aug 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 90.14% 94.93% +4.78%
==========================================
Files 15 15
Lines 335 296 -39
Branches 176 149 -27
==========================================
- Hits 302 281 -21
+ Misses 27 15 -12
+ Partials 6 0 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/runtime/isOldIE.js
Outdated
| typeof document !== "undefined" && | ||
| document.all && | ||
| !window.atob, | ||
| !globalThis.atob, |
Member
There was a problem hiding this comment.
Don't use globalThis in runtime code
alexander-akait
requested changes
Jul 31, 2025
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Let's fix a problem with globalThis
src/runtime/isOldIE.js
Outdated
| // @see https://github.com/webpack-contrib/style-loader/issues/177 | ||
| memo = Boolean( | ||
| typeof window !== "undefined" && | ||
| typeof window.window !== "undefined" && |
alexander-akait
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No