chore: upgrade eslint from v8 to v9#536
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 91.55% 93.03% +1.47%
==========================================
Files 7 7
Lines 604 660 +56
Branches 198 217 +19
==========================================
+ Hits 553 614 +61
+ Misses 42 37 -5
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
updating snapshots creates a new file on its own causing lint and snapshot failure |
|
Do we use old? If no just remove them |
yes, we are using both. |
.cspell.json
Outdated
| "coverage", | ||
| "*.log" | ||
| "*.log", | ||
| "test/lock-files/url/**" |
There was a problem hiding this comment.
Let's save it in test/outputs, we are ignoring this path by default - https://github.com/webpack/eslint-config-webpack/blob/main/ignore-paths.js#L55C8-L55C15, just change a test
There was a problem hiding this comment.
we need to ignore it in cspell.json
.prettierignore
Outdated
| /test/fixtures | ||
| CHANGELOG.md No newline at end of file | ||
| CHANGELOG.md | ||
| test/lock-files/url/** No newline at end of file |
There was a problem hiding this comment.
And remove it from here
There was a problem hiding this comment.
we need to ignore it in prettier too
eslint.config.mjs
Outdated
|
|
||
| export default defineConfig([ | ||
| { | ||
| ignores: ["test/lock-files/url/**"], |
2 participants
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No