Merged
Conversation
Enable WebGPU Compatibility Mode for all samples that can run unmodified in that mode.
Contributor
|
Change looks fine, but I wanted to confirm the expected behavior:
Correct? If so, LGTM! |
Collaborator
The sample will start getting using a compat (but d3d12/vulkan/metal) device in this case, but since the samples don't use any compat features it doesn't have an effect except for a little extra runtime validation |
toji
approved these changes
Jan 17, 2025
Contributor
toji
left a comment
There was a problem hiding this comment.
Thanks for the clarification, Kai! LGTM, I just wanted to ensure this wasn't going to inadvertently downgrade the adapters for these samples.
SenorBlanco
added a commit
to SenorBlanco/webgpu-samples
that referenced
this pull request
Jan 21, 2025
This reverts commit 0ce1ef2.
Collaborator
|
We realized this will break in Chrome <133 with |
kainino0x
added a commit
that referenced
this pull request
Jan 21, 2025
This reverts commit 0ce1ef2.
kainino0x
added a commit
that referenced
this pull request
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable WebGPU Compatibility Mode for all samples that can run unmodified in that mode.