Open
Conversation
PacoMojica
reviewed
Mar 12, 2021
PacoMojica
left a comment
PacoMojica
left a comment
There was a problem hiding this comment.
Hi Mike 👋 I could not create a review for some reason, you are making a good progress, some comments
- You are already using routes
- I really like the custom hooks you have 👌, and also you are testing the new functionality
- I like the little icons in the video description with the statistics and the like button
- You are mocking data in your tests
- I like that you can hit enter in the search bar and run the search
Your delivery looks good to me, great work!! 👍
| --------------------------|----------|----------|----------|----------|-------------------| | ||
| File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s | | ||
| --------------------------|----------|----------|----------|----------|-------------------| | ||
| All files | 63.38 | 21.43 | 46.34 | 63.31 | | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.