Open
Conversation
UriConMur
changed the title
erickwize
approved these changes
Feb 27, 2021
erickwize
left a comment
erickwize
left a comment
There was a problem hiding this comment.
Comment (Mini challenge 1 & 2)
Awesome job Uri! That's actually a nice code to read and understand. It has a lot of advanced topics and best practices for real projects. I see that you have a ton of experience writing React. You didn't get into the 60% coverage threshold because you added so much effort on good practices and awesome code, I know you will make it the consecutive deliverables. I also wanted to congratulate you and call out the awesome theme thing (including the sound 😊 ).
Acceptance Criteria (Mini challenge 1)
- The header is rendered correctly.
- A list of videos obtained from a mock file is displayed in the Home View.
- CSS styles are applied correctly using the styled-components approach.
Bonus Points (Mini challenge 1)
- No warnings or errors are logged in the browser console.
- The UI is responsive
Acceptance Criteria (Mini challenge 2)
- Meaningful test cases were implemented for components and sub-routines logic.
- All the test cases were successful.
Bonus Points ( Mini challenge 2)
- Test coverage is above 60%.
| @@ -0,0 +1 @@ | |||
| FAST_REFRESH=false No newline at end of file | |||
There was a problem hiding this comment.
I don't know if this file was intended to be tracked. I see the .env.sample
Comment on lines
+6
to
+8
| | Statements | Branches | Functions | Lines | | ||
| | --------------------------- | ----------------------- | ------------------------- | ----------------- | | ||
| |  |  |  |  | |
| @@ -0,0 +1,17 @@ | |||
| # Src Structure | |||
There was a problem hiding this comment.
This is the first PR that contains documentation updates. This is awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :)
Please try the application using this link: https://uri-react.netlify.app/
Deliverable 1:
+++ Easter Egg 🥚