🔧 update (cli): add --docker flag for container environments#55
Open
youhanasheriff wants to merge 1 commit intowarengonzaga:devfrom
Open
🔧 update (cli): add --docker flag for container environments#55youhanasheriff wants to merge 1 commit intowarengonzaga:devfrom
youhanasheriff wants to merge 1 commit intowarengonzaga:devfrom
Conversation
Contributor
Author
|
Hey @warengonzaga, this PR is rebased on the latest Changes from original #40:
This supersedes #40 which was auto-closed after the rebase force-push. Sorry about that! |
8 tasks
Add container environment detection and --docker flag to route setup to the web-based flow, preventing CLI prompts from hanging in non-TTY container environments. Changes: - Add isRunningInContainer() in detect-container.ts (shared utility) - Auto-detect Docker/CI via env vars, .dockerenv, and cgroup - Add --docker flag as alias for --web in container contexts - Show container warning in interactive setup with escape hatch - Update help text with --docker documentation
youhanasheriff
force-pushed
the
fix/docker-setup-flag
branch
from
1a1fbd6 to
554d031
Compare
Owner
|
It is indeed clean! The ones that you are seeing is that bot has no access to my keys. Looks like the action here does not use the latest action from main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dockerflag that routes to web-based setup (same as--web)CI,CONTAINER,DOCKER_CONTAINERenv vars,/.dockerenvfile, and/proc/1/cgroupcontainer indicatorsisRunningInContainer()intodetect-container.ts--dockerdocumentationTesting
isRunningInContainer()returnsfalseon local macOSisRunningInContainer()returnstruewithCI=trueisRunningInContainer()returnstruewithCONTAINER=1isRunningInContainer()returnstruewithDOCKER_CONTAINER=1--dockerflag routes to web/supervisor mode--webflag still works--dockerdocumentationtinyclaw setup --dockerin a container environmentRelated Issue
Closes #12
Checklist