T7195: remove an accidentally committed object file and add a proper .gitignore#14
Merged
sever-sever merged 2 commits intovyos:currentfrom Feb 25, 2025
Merged
Conversation
sever-sever
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
A build artifact was accidentally committed to ipaddrcheck (https://github.com/vyos/ipaddrcheck/blob/current/src/ipaddrcheck_functions.o) — due to my double negligence: I didn't add a proper .gitignore to it from the start and didn't notice a .o file in git status before committing.
That was the cause of floating CI failures after the fix for T6744: the fix does work, but when a compiled object file is present, recursive make may assume that it doesn't need to be built, so an outdated code ends up in the binary, instead of the fixed code in ipaddrcheck_functions.c
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
Checklist: