Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions encodings/fastlanes/src/bitpacking/vtable/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,18 @@ impl VTable for BitPacked {
}

fn serialize(metadata: Self::Metadata) -> VortexResult<Option<Vec<u8>>> {
vortex_ensure!(
metadata.offset == 0,
"BitPackedArray offset must be 0 for serialization, got {}",
metadata.offset
);
if let Some(ref patches) = metadata.patches {
vortex_ensure!(
patches.offset()? == 0,
"BitPackedArray patches offset must be 0 for serialization, got {}",
patches.offset()?
);
}
Ok(Some(metadata.serialize()))
}

Expand Down
5 changes: 5 additions & 0 deletions encodings/fastlanes/src/delta/vtable/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,11 @@ impl VTable for Delta {
}

fn serialize(metadata: Self::Metadata) -> VortexResult<Option<Vec<u8>>> {
vortex_ensure!(
metadata.offset == 0,
"DeltaArray offset must be 0 for serialization, got {}",
metadata.offset
);
Ok(Some(metadata.0.encode_to_vec()))
}

Expand Down
22 changes: 10 additions & 12 deletions encodings/fastlanes/src/rle/array/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,18 +504,16 @@ mod tests {
let concat = concat.freeze();

let parts = ArrayParts::try_from(concat).unwrap();
let decoded = parts
.decode(
sliced.dtype(),
sliced.len(),
&ReadContext::new(ctx.to_ids()),
&SESSION,
)
.unwrap();

let original_data = sliced.to_primitive();
let decoded_data = decoded.to_primitive();
let decoded = parts.decode(
sliced.dtype(),
sliced.len(),
&ReadContext::new(ctx.to_ids()),
&SESSION,
);

assert_arrays_eq!(original_data, decoded_data);
assert_eq!(
decoded.err().unwrap().to_string(),
"Other error: RLEArray offset must be 0 for serialization, got 100"
);
}
}
5 changes: 5 additions & 0 deletions encodings/fastlanes/src/rle/vtable/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ impl VTable for RLE {
}

fn serialize(metadata: Self::Metadata) -> VortexResult<Option<Vec<u8>>> {
vortex_ensure!(
metadata.offset == 0,
"RLEArray offset must be 0 for serialization, got {}",
metadata.offset
);
Ok(Some(metadata.0.encode_to_vec()))
}

Expand Down
5 changes: 5 additions & 0 deletions encodings/runend/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ impl VTable for RunEnd {
}

fn serialize(metadata: Self::Metadata) -> VortexResult<Option<Vec<u8>>> {
vortex_ensure!(
metadata.offset == 0,
"RunEndArray offset must be 0 for serialization, got {}",
metadata.offset
);
Ok(Some(metadata.serialize()))
}

Expand Down
Loading