Skip to content

do not validate already valid arrow varbin arrays #7089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onursatici merged 1 commit into from
Mar 20, 2026
+9 −6
Merged

do not validate already valid arrow varbin arrays #7089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions vortex-array/src/arrow/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,15 @@ where
DataType::Utf8 | DataType::LargeUtf8 => DType::Utf8(nullable.into()),
dt => vortex_panic!("Invalid data type for ByteArray: {dt}"),
};
Copy link
Contributor

@joseph-isaacs joseph-isaacs Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least to a debug assert here

Copy link
Contributor Author

@onursatici onursatici Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_unchecked has this under new_unchecked_from_handle:

        #[cfg(debug_assertions)]
        Self::validate(&offsets, &bytes, &dtype, &validity)
            .vortex_expect("[Debug Assertion]: Invalid `VarBinArray` parameters");

so we already have dbg assert validate here

Ok(VarBinArray::try_new(
value.offsets().clone().into_array(),
ByteBuffer::from_arrow_buffer(value.values().clone(), Alignment::of::<u8>()),
dtype,
nulls(value.nulls(), nullable),
)?
// SAFETY: Arrow arrays are already validated (valid UTF-8, valid offsets, correct validity).
Ok(unsafe {
VarBinArray::new_unchecked(
value.offsets().clone().into_array(),
ByteBuffer::from_arrow_buffer(value.values().clone(), Alignment::of::<u8>()),
dtype,
nulls(value.nulls(), nullable),
)
}
.into_array())
}
}
Expand Down
Loading