fix(openclaw-plugin): avoid shared mutable agent client state#867
Open
ningfeemic-dev wants to merge 1 commit intovolcengine:mainfrom
Open
fix(openclaw-plugin): avoid shared mutable agent client state#867ningfeemic-dev wants to merge 1 commit intovolcengine:mainfrom
ningfeemic-dev wants to merge 1 commit intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
ab02e02 to
7f560be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenClaw plugin currently reuses a shared
OpenVikingClientand switches identity via mutablesetAgentId(...)calls.Under concurrent multi-agent usage, that can leak agent context across requests.
Fix
Use agent-scoped client instances instead of mutating a shared client instance:
agentIdsetAgentId(...)in hot pathsWhy this is needed
This is an isolation fix, not a refactor.
It reduces the risk that:
Validation
./node_modules/.bin/tsc -p tsconfig.json --noEmit