Skip to content

refactor: remove conditional disableDistinct and make it always enabled #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tpluscode wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −4
Open

refactor: remove conditional disableDistinct and make it always enabled #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d984334
refactor: remove conditional `disableDistinct` and make it always ena…
tpluscode Jan 21, 2026
29eaf2f
chore: change
tpluscode Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ You can also check the

## Unreleased

Nothing yet.
### Changed

- Improve cube query performance by removing expensive `DISTINCT` and `GROUP BY` clauses from SPARQL queries

### 6.2.5 - 2025-12-02

Expand Down
5 changes: 2 additions & 3 deletions app/rdf/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ export const getCubeObservations = async ({
preview,
limit,
observationsView,
disableDistinct: !filters || Object.keys(filters).length === 0,
});

const serverFilter =
Expand Down Expand Up @@ -723,13 +722,13 @@ async function fetchViewObservations({
preview,
limit,
observationsView,
disableDistinct,
}: {
preview?: boolean | null;
limit?: number | null;
observationsView: View;
disableDistinct: boolean;
}) {
const disableDistinct = true

/**
* Add LIMIT to query
*/
Expand Down
Loading