Add Language::between_chunks and between_value_and_word#36
Merged
Conversation
These methods make it possible to customize the whitespace in the output. This enables additional punctuation (like the commas proposed in vi#11) and abbreviated output formats (often desired in command-line applications, like `1h 30m 15s`). The default implementations encode the previous behavior; therefore, no change is made to the observed behavior of the library.
9999years
added a commit
to 9999years/timeago
that referenced
this pull request
Aug 28, 2025
This adds a new `EnglishAbbreviated` `Language` which takes advantage of the additional `Language` methods introduced in vi#36 in order to produce more compact output. I'm not sure this feature is appropriate for this library (none of the other `Language`s encode stylistic opinions like this), but I wanted to demonstrate the usage of the features.
vi
reviewed
Aug 28, 2025
| (true, false) => format!("{word} {x} {recurse_result}"), | ||
| (false, true) => format!("{x} {word}"), | ||
| (false, false) => format!("{x} {word} {recurse_result}"), | ||
| (true, true) => format!("{word}{between}{x}"), |
Owner
There was a problem hiding this comment.
Are inline format strings supported by the Rust version this crate aims to support?
Contributor
Author
There was a problem hiding this comment.
I assume so, because they're used in the version on master as well (e.g. in format!("{word} {x} {recurse_result}"), all the variables are captured from the local scope like {between} is in the changed version).
Thanks for the quick review, I saw the repo wasn't very active so I figured I was just shouting into the void :)
Contributor
Author
There was a problem hiding this comment.
cargo +1.63 test passed (on my machine at least), so I think we're good!
9999years
added a commit
to 9999years/timeago
that referenced
this pull request
Aug 29, 2025
This adds a new `EnglishAbbreviated` `Language` which takes advantage of the additional `Language` methods introduced in vi#36 in order to produce more compact output. I'm not sure this feature is appropriate for this library (none of the other `Language`s encode stylistic opinions like this), but I wanted to demonstrate the usage of the features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods make it possible to customize the whitespace in the output. This enables additional punctuation (like the commas proposed in #11) and abbreviated output formats (often desired in command-line applications, like
1h 30m 15s).The default implementations encode the previous behavior; therefore, no change is made to the observed behavior of the library.
For an example using this feature, see #37.