Reorder dmon startup so available for onload (SYN-10076)#4751
Open
mikemoritz wants to merge 8 commits intomasterfrom
Open
Reorder dmon startup so available for onload (SYN-10076)#4751mikemoritz wants to merge 8 commits intomasterfrom
mikemoritz wants to merge 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 298 298
Lines 62352 62365 +13
==========================================
+ Hits 60941 60953 +12
- Misses 1411 1412 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vEpiphyte
reviewed
Feb 26, 2026
# Conflicts: # synapse/cortex.py
vEpiphyte
reviewed
Mar 9, 2026
|
|
||
| async def safeKill(self): | ||
| if self.protected: | ||
| raise s_exc.SynErr(mesg=f'Task {self.name} is protected.') |
Contributor
There was a problem hiding this comment.
Suggested change
| raise s_exc.SynErr(mesg=f'Task {self.name} is protected.') | |
| raise s_exc.SynErr(mesg=f'Task {self.name} is protected.', iden=self.iden) |
vEpiphyte
reviewed
Mar 9, 2026
| with self.getTestDir(copyfrom=dirn) as regrdir: | ||
| yield regrdir | ||
|
|
||
| async def waitForActiveMigration(self, core): |
Contributor
There was a problem hiding this comment.
This should have a timeout so we don't potentially block forever in a failed migration case.
vEpiphyte
reviewed
Mar 9, 2026
| for pkgdef in list(self.stormpkgs.values()): | ||
| self._runStormPkgOnload(pkgdef) | ||
|
|
||
| self._migration_evnt.set() |
Contributor
There was a problem hiding this comment.
Should this event be cleared when we go inactive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.