ICSAAS-408 add datalayer to search and searchtab cmps#147
ICSAAS-408 add datalayer to search and searchtab cmps#147igorsimovski wants to merge 3 commits intomainfrom
Conversation
igorsimovski
commented
Mar 4, 2022
igorsimovski
commented
- update json export for each
- update FE to include the dataLayer in the markup
- update json export for each - update FE to include the dataLayer in the markup
| </dependency> | ||
| <dependency> | ||
| <groupId>com.adobe.cq</groupId> | ||
| <artifactId>core.wcm.components.core</artifactId> |
There was a problem hiding this comment.
oh we have now a hard dependency on core components, right? because of the interface & utility function?
I am just bit worried because this can conflict with a client core component version...
There was a problem hiding this comment.
let's discuss this in some call
There was a problem hiding this comment.
@igorsimovski : how much code would you need to clone of we don't add the dependency?
I'd like to avoid adding the dependency to core competents to not dictate that and which version needs to be used by the client
There was a problem hiding this comment.
Just a thought: can't this be overcome with a specific entry in the Import-Package section in the client project?
There was a problem hiding this comment.
@igorsimovski : how much code would you need to clone of we don't add the dependency?
com.adobe.cq.wcm.core.components.models.datalayer.ComponentData (we use the getData method from this interface)
com.adobe.cq.wcm.core.components.internal.jackson.ComponentDataModelSerializer (this is the serializer for the field/'json property' associated with getData())
com.adobe.cq.wcm.core.components.util.ComponentUtils (to check if data layer is enabled in CA configs - This can be omitted either by making our own ca config or rely only on a dataLayer on/off switch in the components)
com.adobe.cq.wcm.core.components.models.datalayer.builder.DataLayerBuilder (this is a rather large implementation that offers a convenient way of building the dataLayer json, but we could do w/o it - we can simply do it with a dedicated POJO for each component)
There was a problem hiding this comment.
Just a thought: can't this be overcome with a specific entry in the Import-Package section in the client project?
There was a problem hiding this comment.
Sorry for my late reply. I think it makes sense to discuss this one to one
…nt_and_Search_Result_Tab # Conflicts: # pom.xml # ui.frontend/src/main/webpack/site/js/types/searchOptions.ts
- initiate DOMContentLoadedEvent after search query (to register tab data layers) - update index.html (tab urls)
|
Kudos, SonarCloud Quality Gate passed! |
2 participants
