feat: add isDuration validator for ms-compatible duration strings#2674
Closed
Azarcodex wants to merge 1 commit intovalidatorjs:masterfrom
Closed
feat: add isDuration validator for ms-compatible duration strings#2674Azarcodex wants to merge 1 commit intovalidatorjs:masterfrom
Azarcodex wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 115 +1
Lines 2592 2603 +11
Branches 660 665 +5
=========================================
+ Hits 2592 2603 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The person that created the issue, also created a PR for it; #2669 . Feel free to review that one, but since this is the duplicate I will be closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2668
Adds a new isDuration(str, options?) validator that checks whether a string
is a valid duration in the format used by the popular
mspackage.This was originally implemented in
typestack/class-validator(issue,
PR), where maintainers
recommended it belong here in validator.js instead.
What isDuration validates
It accepts duration strings matching the
mspackageStringValueformat:'100','3.5''10s','2m','1h','7d''10 ms','2 h','5 w''2 minutes','3 hours','4 days''1.5h','0.5 days','2.75 weeks''2 Days','5 HOURS','10MS'Supported unit aliases
years,year,yrs,yr,ymonths,month,moweeks,week,wdays,day,dhours,hour,hrs,hr,hminutes,minute,mins,min,mseconds,second,secs,sec,smilliseconds,millisecond,msecs,msec,msOptions
allowNegativebooleantrue'-1h'are considered validUsage