Update all dependencies to fix vulnerabilities #277
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,29 +47,29 @@ | |||||
| "test:watch": "node --test --watch" | ||||||
| }, | ||||||
| "dependencies": { | ||||||
| "lodash": "^4.17.23" | ||||||
| }, | ||||||
| "devDependencies": { | ||||||
| "@fastify/pre-commit": "^2.2.1", | ||||||
| "@uphold/github-changelog-generator": "^4.0.2", | ||||||
| "abavalidator": "^2.0.2", | ||||||
| "bignumber.js": "^9.3.1", | ||||||
|
Contributor
There was a problem hiding this comment. maybe we can consider bumping this to next major release (10.0.2), to avoid updating to a 8 months old version in a separate pr (we're using |
||||||
| "cpf": "^2.0.1", | ||||||
| "creditcard": "^0.1.3", | ||||||
| "curp": "^1.3.1", | ||||||
| "eslint": "~9.39.2", | ||||||
|
Contributor
There was a problem hiding this comment. maybe we should consider updating it to latest major as well (10.0.3) in a separate pr? |
||||||
| "eslint-config-uphold": "^6.9.0", | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| "google-libphonenumber": "^3.2.43", | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| "iban": "0.0.6", | ||||||
| "isoc": "0.0.1", | ||||||
| "moment": "^2.30.1", | ||||||
| "prettier": "^3.8.0", | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| "release-it": "^19.2.4", | ||||||
| "tin-validator": "^1.1.0", | ||||||
| "uk-modulus-checking": "0.0.3", | ||||||
| "urijs": "^1.17.1", | ||||||
| "validate-rfc": "^2.0.3", | ||||||
| "validator": "^13.15.26", | ||||||
| "validator.js": "^2.0.0" | ||||||
| }, | ||||||
| "peerDependencies": { | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of bignumber.js to version 9.3.1 conflicts with the peerDependencies constraint which specifies ">=7 || <=9.3.0" (line 77) and the optionalPeerDependencies constraint ">=7 <=9.3.0" (line 141). The devDependency is being updated to ^9.3.1, which is outside the acceptable peer dependency range. This means that consumers of this package would see peer dependency warnings if they use bignumber.js 9.3.1 or higher.
Either update the peerDependencies constraints to allow 9.3.1 (e.g., ">=7 <=9.3.1" or ">=7 <9.4.0"), or keep bignumber.js at 9.3.0 if there's a specific reason for the upper bound constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/uphold/validator.js-asserts/pull/277/changes#r2923543857