Open
Conversation
Author
|
@ueman Thanks for creating this package :) Please review API and let me know what you think. Once API is approved, appropriate tests can be added. |
e8a1d2e to
df234c7
Compare
Owner
|
Hey, thanks for the contribution. The API seems perfectly fine for me. Thanks for working on it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 83.77% 83.77% -0.01%
==========================================
Files 20 20
Lines 635 641 +6
==========================================
+ Hits 532 537 +5
- Misses 103 104 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds the option to define
supportedModesso that, for instance,FeedbackMode.navigateis not displayed.💡 Motivation and Context
For a single page desktop application, the
navigateoption may not be required. Moreover, the user can continue to interact with the application as usual (i.e. right click), thus there can be cases where we do not want to allow the user to interact while the feedback window is open.Conversely, I am not sure if there are real-world use-cases where the user can interact/navigate but not draw, nevertheless those would be covered by this PR.
💚 How did you test it?
Update
example/lib/main.dart, changesupportedModesaccordingly.Technically the user can select
which is non-sensical. A check in
FeedbackWidgetensures correct state, however the api could be updated, i.e. first value ofsupportedModes.Moreover, assets/errors could be raised when
supportedModesis empty;📝 Checklist
🔮 Next steps
FeedbackMode.navigateperhaps needs a renaming tointeractive. This, perhaps, could be more descriptive. Such a change, however, would be a breaking change best suited to another PR.modewas left as-is to not introduce any breaking changes (see discussion above).