Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 88.40% 84.08% -4.32%
==========================================
Files 3 6 +3
Lines 1095 1257 +162
==========================================
+ Hits 968 1057 +89
- Misses 127 200 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I think some more test cases for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
drainandsplicemethods forEcoVec, the implementation of these have been mostly copy pasted from the standard libaray.A few more methods for mutating parts of an
EcoStringthat are not at the end are also added:removeinsertinsert_strNotably this doesn't implement
EcoString::drain, because the returned type would have to be some sort of fusion of the inline vs spilled drain implementation, which seemed a bit inelegant and too much work to implement.Miri also seems to be happy :)