Open
Conversation
- Change existing markdownRule syntax matching rules to match only if preceded by 0-3 spaces and nothing else (in accordance with CommonMark) - Add support for horizontal rules (thematic breaks) using underscores (in accordance with John Gruber's original spec and CommonMark) - Change the italic and bold syntax matching so that they do not collide with horizontal rules composed of asterisks or underscores
Author
|
I apologize for the repeated notifications; I accidentally pushed another commit to this branch just now. This should now be fixed (I force-pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdownRulenow only matches if a line contains 0-3 spaces followed by the characters forming the rule (e.g.␣␣*␣*␣*␣*␣*), with nothing else on the line. This is in accordance with CommonMark (and compatible with the original spec, which does not allow whitespace before the characters forming the rule).Screenshot