Fixing some italics syntax consistency issues#16
Fixing some italics syntax consistency issues#16ryankinderman wants to merge 1 commit intotpope:masterfrom
Conversation
ryankinderman
commented
Apr 15, 2012
- Added skipping escaped italics tokens when end matching
- Updated prefix/suffix constraints for start/end patterns to be more consistent with behavior of the Markdown Dingus
- Added constraint on start pattern so that it doesn't match if there isn't an end token within the same paragraph
- Added sample.md to syntax dir to use for testing syntax consistency w/the dingus
…t patterns to not match if not followed by the end token in the same paragraph, and to not match on start or end patterns if improperly prefixed or suffixed in a way more consistent with the markdown dingus
|
Interesting work. However, I believe there are still some cases that are not covered. For example: The second title does not get correct syntax highlighting, even not after patching. |
|
Yea, I'm sure there are cases that still aren't covered. I basically tried to fix the handful of cases that were not working for me at the time. It's hard to be comprehensive with nothing to use as a reference except the "Dingus". Would love to see others jump in and fix things that are still missing. |
|
I tried it and I get a similar bug as @RubenVerborgh, but slightly different. In his example, the Title doesn't get highlighted. In my case just every The bug I describe here is not present in @tpope's current master |