Improve QuerySet integer-indexing error guidance#2093
Open
sam-dawnops wants to merge 1 commit intotortoise:developfrom
Open
Improve QuerySet integer-indexing error guidance#2093sam-dawnops wants to merge 1 commit intotortoise:developfrom
sam-dawnops wants to merge 1 commit intotortoise:developfrom
Conversation
Pull Request Test Coverage Report for Build 21883100900Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a dedicated
ParamsErrormessage for integer indexing onQuerySetand cover it with a regression test.Motivation and Context
QuerySetis lazy and supports slicing, butqueryset[5]currently raises a generic message. This change makes that failure mode clearer and tells users how to evaluate/query for a single item correctly.How Has This Been Tested?
uv run --frozen --group test --group contrib --extra psycopg pytest -q tests/test_queryset.pyuv run --frozen --group dev ruff check tests/test_queryset.py tortoise/queryset.pyChecklist: