Feat: Improved forensics for exceptions raised in get_create_schema_sql#1236
Open
caniko wants to merge 5 commits intotortoise:developfrom
Open
Feat: Improved forensics for exceptions raised in get_create_schema_sql#1236caniko wants to merge 5 commits intotortoise:developfrom
get_create_schema_sql#1236caniko wants to merge 5 commits intotortoise:developfrom
Conversation
added 3 commits
August 30, 2022 18:10
The previous version of the function lacked granularity for raising errors with proper forensics. This commit introduces a different implementation that should be enabling.
caniko
changed the title
get_create_schema_sql
Chore: Ran black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous version of the function lacked granularity for raising errors with proper forensics. This commit introduces a different implementation that should be enabling.
Motivation and Context
How Has This Been Tested?
poetry run make testallGot 4 fails.
Checklist: