Answer:1 Projection #1409
Open
Answer:1 Projection #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gw0zdziu
commented
Dec 26, 2025
Gw0zdziu
commented
- refactor CardComponent
- refactor ListItemComponent
- declare "@for" in CardComponent
- delete conditions in CardComponent
tomalaforge
added
answer
tomalaforge
reviewed
Dec 30, 2025
| template: ` | ||
| <div | ||
| class="flex w-fit flex-col gap-3 rounded-md border-2 border-black p-4" | ||
| [class]="customClass()"> |
Owner
There was a problem hiding this comment.
instead of wrapping your component inside another div, you can use the host metadata property
@Component({
host: {
class: `xxx``
}
}
tomalaforge
reviewed
Dec 30, 2025
| [name]="item.firstName" | ||
| [id]="item.id" | ||
| [type]="type()"></app-list-item> | ||
| @for (item of list(); let i = $index; track i) { |
Owner
There was a problem hiding this comment.
if possible it's better to track on a unique property like an id,
to be sure that list has an id, you can do CardComponent<T extends {id: string}>
also, you don't have to declare i you can use $index directly inside the @for
tomalaforge
reviewed
Dec 30, 2025
| const directive = new OptionTemplateDirective(); | ||
| expect(directive).toBeTruthy(); | ||
| }); | ||
| }); |
Owner
There was a problem hiding this comment.
this test is a bit useless 😅
tomalaforge
reviewed
Dec 30, 2025
| } | ||
| readonly optionTemplateRef = contentChild(OptionTemplateDirective, { | ||
| read: TemplateRef, | ||
| }); |
tomalaforge
reviewed
Dec 30, 2025
| <ng-template appOptionTemplate let-city> | ||
| <app-list-item> | ||
| <ng-container ngProjectAs="item-name">{{ city.name }}</ng-container> | ||
| <button ngProjectAs="item-action" (click)="delete(city.id)"> |
Owner
There was a problem hiding this comment.
ngProjectAs is not needed here, but you can use it if you prefer
tomalaforge
reviewed
Dec 30, 2025
| private store = inject(CityStore); | ||
|
|
||
| cities = this.store.cities; | ||
| cardType = CardType.CITY; |
tomalaforge
reviewed
Dec 30, 2025
| class="rounded-sm border border-blue-500 bg-blue-300 p-2" | ||
| (click)="addNewItem()"> | ||
| Add | ||
| </button> |
Owner
There was a problem hiding this comment.
you can add the button to list-item, that's a common button for all cards
Owner
|
Nice work and thanks for sponsoring the project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.