Fix for issue #57 and fixed a few lints. #58
Open
bsutton wants to merge 2 commits intotjarvstrand:mainfrom
Open
Fix for issue #57 and fixed a few lints. #58bsutton wants to merge 2 commits intotjarvstrand:mainfrom
bsutton wants to merge 2 commits intotjarvstrand:mainfrom
Conversation
Author
|
added a new unit test to ensure the list of timezones was being pulled. |
tjarvstrand
requested changes
Feb 17, 2026
Owner
tjarvstrand
left a comment
tjarvstrand
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay. Had a baby about a month ago so things have been a little out of wack 🙂
Looks good overall! Just one minor comment.
| if (values == null) { | ||
| return [_getLocalTimeZone()]; | ||
| } | ||
| return values.toDart.map((value) => value.toDart).toList(growable: false); |
Owner
There was a problem hiding this comment.
Please change this to return a standard, growable, list.
I'm all for immutable (and by extension fixed size) collections, but then it should be reflected in the function signature. Using a fixed size list here seems like premature optimization and since it's hidden behind the interface it would definitely bite someone at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.