feat: recover corrupted tail automatically#22
Open
yihuang wants to merge 2 commits intotidwall:masterfrom
Open
feat: recover corrupted tail automatically#22yihuang wants to merge 2 commits intotidwall:masterfrom
yihuang wants to merge 2 commits intotidwall:masterfrom
Conversation
Solution: - auto-recover the corrupted tail
yihuang
changed the title
2 tasks
imih
reviewed
Apr 25, 2025
| DirPerms os.FileMode | ||
| FilePerms os.FileMode | ||
| // RecoverCorruptedTail will attempt to recover a corrupted tail in the last segment automatically. | ||
| RecoverCorruptedTail bool |
There was a problem hiding this comment.
iiuc, the following scenarios would also need to be handled for completeness:
- partial writes of payload, following the offset (i.e. when
s.ebuf = ebuf[:pos]assignment below panics) - finding the last segment with non-corrupted data (the existing last segment file may only have corrupted data if e.g. it's 0 byte or the first entry is corrupted). We should delete that file and attempt reading second-to-last one (preferably with recoverCorruptedTail=false)
- the last segment post-recovery must have non-zero entries or whatever is appropriate considering feat: TruncateFront & TruncateBack support truncating all entries #31
Author
There was a problem hiding this comment.
thanks for the feedback, will think it through tmr, it's late here ;D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
Closes: #21