Open
Conversation
This commit avoids a few conversions of multiplications done in a narrow type that can (theoretically) overflow before being converted to a wider type. These changes ensure the conversion is always done in the wider type so there's no risk of overflow. This is fairly theoretical for TGUI usage, but it's better to be correct than to fail in some user corner case. There are a few more cases like this elsewhere in the library and I'll fix those up in the future if this commit is merged. (also change const to constexpr where constant evaluation is actually possible).
Make sure we always std::forward arguments and make the code a bit easier to read.
The URLs https://tgui.eu/tutorials/1.0/ and https://tgui.eu/examples/1.0 don't exist any more, so update those to just point to https://tgui.eu/tutorials/latest-stable/ The URL https://tgui.eu is strictly speaking not correct, it should be https://tgui.eu/
Owner
|
I don't think the widening casts are needed. They just make the code harder to read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few small changes.