Skip to content

typing: Correct type of TestCase.skipTest #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelmer merged 1 commit into from
Mar 13, 2026
Merged

typing: Correct type of TestCase.skipTest #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testtools/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import types
import unittest
from collections.abc import Callable, Iterator
from typing import TYPE_CHECKING, ParamSpec, TypeVar, cast, overload
from typing import TYPE_CHECKING, NoReturn, ParamSpec, TypeVar, cast, overload
from unittest.case import SkipTest

T = TypeVar("T")
Expand Down Expand Up @@ -366,7 +366,7 @@ def patch(self, obj: object, attribute: str, value: object) -> None:
def shortDescription(self) -> str:
return self.id()

def skipTest(self, reason: str) -> None: # type: ignore[override]
def skipTest(self, reason: str) -> NoReturn:
"""Cause this test to be skipped.

This raises self.skipException(reason). skipException is raised
Expand Down