Merged
Conversation
jelmer
reviewed
Mar 6, 2026
jelmer
reviewed
Mar 6, 2026
jelmer
requested changes
Mar 6, 2026
Member
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
Overall LGTM. Some inline comments. Please also take a look at the failing tests.
unittest2 has not had a release in a decade [1]. [1] https://pypi.org/project/unittest2/ Signed-off-by: Stephen Finucane <stephen@that.guru>
The only meaningful change is that we now set requires-python, but we haven't supported Python 2 is a long time so that's not a big issue. Signed-off-by: Stephen Finucane <stephen@that.guru>
We also bump the GitHub Actions versions. Signed-off-by: Stephen Finucane <stephen@that.guru>
This aligns us with testtools. Signed-off-by: Stephen Finucane <stephen@that.guru>
Contributor
Author
I finally got around to addressing these plus the test failure (from additional ruff rules that I hadn't actually fixed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.